Add more specific testing advice to Contributing.md

This commit is contained in:
sshleifer 2020-02-11 14:41:29 -05:00 committed by Lysandre Debut
parent ee5de0ba44
commit 5dd61fb9a9

View File

@ -198,8 +198,11 @@ Follow these steps to start contributing:
3. To indicate a work in progress please prefix the title with `[WIP]`. These 3. To indicate a work in progress please prefix the title with `[WIP]`. These
are useful to avoid duplicated work, and to differentiate it from PRs ready are useful to avoid duplicated work, and to differentiate it from PRs ready
to be merged; to be merged;
4. Make sure pre-existing tests still pass; 4. Make sure existing tests pass;
5. Add high-coverage tests. No quality test, no merge; 5. Add high-coverage tests. No quality test, no merge.
If you are adding a new model, make sure that you use `ModelTester.all_model_classes`, which triggers the common tests.
If you are adding new `@slow` tests, make sure they pass using `RUN_SLOW=1 python -m pytest tests/test_my_new_model.py`.
CircleCI does not run them.
6. All public methods must have informative docstrings; 6. All public methods must have informative docstrings;