riaz.somc/transformers
1
0
Fork 0
mirror of https://github.com/huggingface/transformers.git synced 2025-07-04 05:10:06 +06:00
Code Issues Actions 26 Packages Projects Releases Wiki Activity

#12789 Replace assert statements with exceptions (#13909)

Browse Source 
* #12789 Replace assert statements with exceptions

* fix-copies: made copy changes to utils_qa.py in examples/pytorch/question-answering and examples/tensorflow/question-answering

* minor refactor for clarity
This commit is contained in:
Dhananjay Shettigar 2021-10-07 18:39:01 +05:30 committed by GitHub
parent 279ce5b705
commit 319beb64eb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 36 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
examples/flax/question-answering/utils_qa.py
View File

@ -73,10 +73,12 @@ def postprocess_qa_predictions(
log_level (:obj:`int`, `optional`, defaults to ``logging.WARNING``): log_level (:obj:`int`, `optional`, defaults to ``logging.WARNING``):
``logging`` log level (e.g., ``logging.WARNING``) ``logging`` log level (e.g., ``logging.WARNING``)
""" """
assert len(predictions) == 2, "`predictions` should be a tuple with two elements (start_logits, end_logits)." if len(predictions) != 2:
raise ValueError("`predictions` should be a tuple with two elements (start_logits, end_logits).")
all_start_logits, all_end_logits = predictions all_start_logits, all_end_logits = predictions
assert len(predictions[0]) == len(features), f"Got {len(predictions[0])} predictions and {len(features)} features." if len(predictions[0]) != len(features):
raise ValueError(f"Got {len(predictions[0])} predictions and {len(features)} features.")
# Build a map example to its corresponding features. # Build a map example to its corresponding features.
example_id_to_index = {k: i for i, k in enumerate(examples["id"])} example_id_to_index = {k: i for i, k in enumerate(examples["id"])}
@ -212,7 +214,8 @@ def postprocess_qa_predictions(
# If we have an output_dir, let's save all those dicts. # If we have an output_dir, let's save all those dicts.
if output_dir is not None: if output_dir is not None:
assert os.path.isdir(output_dir), f"{output_dir} is not a directory." if not os.path.isdir(output_dir):
raise EnvironmentError(f"{output_dir} is not a directory.")
prediction_file = os.path.join( prediction_file = os.path.join(
output_dir, "predictions.json" if prefix is None else f"{prefix}_predictions.json" output_dir, "predictions.json" if prefix is None else f"{prefix}_predictions.json"
@ -283,12 +286,12 @@ def postprocess_qa_predictions_with_beam_search(
log_level (:obj:`int`, `optional`, defaults to ``logging.WARNING``): log_level (:obj:`int`, `optional`, defaults to ``logging.WARNING``):
``logging`` log level (e.g., ``logging.WARNING``) ``logging`` log level (e.g., ``logging.WARNING``)
""" """
assert len(predictions) == 5, "`predictions` should be a tuple with five elements." if len(predictions) != 5:
raise ValueError("`predictions` should be a tuple with five elements.")
start_top_log_probs, start_top_index, end_top_log_probs, end_top_index, cls_logits = predictions start_top_log_probs, start_top_index, end_top_log_probs, end_top_index, cls_logits = predictions
assert len(predictions[0]) == len( if len(predictions[0]) != len(features):
features raise ValueError(f"Got {len(predictions[0])} predictions and {len(features)} features.")
), f"Got {len(predictions[0])} predicitions and {len(features)} features."
# Build a map example to its corresponding features. # Build a map example to its corresponding features.
example_id_to_index = {k: i for i, k in enumerate(examples["id"])} example_id_to_index = {k: i for i, k in enumerate(examples["id"])}
@ -400,7 +403,8 @@ def postprocess_qa_predictions_with_beam_search(
# If we have an output_dir, let's save all those dicts. # If we have an output_dir, let's save all those dicts.
if output_dir is not None: if output_dir is not None:
assert os.path.isdir(output_dir), f"{output_dir} is not a directory." if not os.path.isdir(output_dir):
raise EnvironmentError(f"{output_dir} is not a directory.")
prediction_file = os.path.join( prediction_file = os.path.join(
output_dir, "predictions.json" if prefix is None else f"{prefix}_predictions.json" output_dir, "predictions.json" if prefix is None else f"{prefix}_predictions.json"

20
examples/pytorch/question-answering/utils_qa.py
View File

@ -73,10 +73,12 @@ def postprocess_qa_predictions(
log_level (:obj:`int`, `optional`, defaults to ``logging.WARNING``): log_level (:obj:`int`, `optional`, defaults to ``logging.WARNING``):
``logging`` log level (e.g., ``logging.WARNING``) ``logging`` log level (e.g., ``logging.WARNING``)
""" """
assert len(predictions) == 2, "`predictions` should be a tuple with two elements (start_logits, end_logits)." if len(predictions) != 2:
raise ValueError("`predictions` should be a tuple with two elements (start_logits, end_logits).")
all_start_logits, all_end_logits = predictions all_start_logits, all_end_logits = predictions
assert len(predictions[0]) == len(features), f"Got {len(predictions[0])} predictions and {len(features)} features." if len(predictions[0]) != len(features):
raise ValueError(f"Got {len(predictions[0])} predictions and {len(features)} features.")
# Build a map example to its corresponding features. # Build a map example to its corresponding features.
example_id_to_index = {k: i for i, k in enumerate(examples["id"])} example_id_to_index = {k: i for i, k in enumerate(examples["id"])}
@ -212,7 +214,8 @@ def postprocess_qa_predictions(
# If we have an output_dir, let's save all those dicts. # If we have an output_dir, let's save all those dicts.
if output_dir is not None: if output_dir is not None:
assert os.path.isdir(output_dir), f"{output_dir} is not a directory." if not os.path.isdir(output_dir):
raise EnvironmentError(f"{output_dir} is not a directory.")
prediction_file = os.path.join( prediction_file = os.path.join(
output_dir, "predictions.json" if prefix is None else f"{prefix}_predictions.json" output_dir, "predictions.json" if prefix is None else f"{prefix}_predictions.json"
@ -283,12 +286,12 @@ def postprocess_qa_predictions_with_beam_search(
log_level (:obj:`int`, `optional`, defaults to ``logging.WARNING``): log_level (:obj:`int`, `optional`, defaults to ``logging.WARNING``):
``logging`` log level (e.g., ``logging.WARNING``) ``logging`` log level (e.g., ``logging.WARNING``)
""" """
assert len(predictions) == 5, "`predictions` should be a tuple with five elements." if len(predictions) != 5:
raise ValueError("`predictions` should be a tuple with five elements.")
start_top_log_probs, start_top_index, end_top_log_probs, end_top_index, cls_logits = predictions start_top_log_probs, start_top_index, end_top_log_probs, end_top_index, cls_logits = predictions
assert len(predictions[0]) == len( if len(predictions[0]) != len(features):
features raise ValueError(f"Got {len(predictions[0])} predictions and {len(features)} features.")
), f"Got {len(predictions[0])} predicitions and {len(features)} features."
# Build a map example to its corresponding features. # Build a map example to its corresponding features.
example_id_to_index = {k: i for i, k in enumerate(examples["id"])} example_id_to_index = {k: i for i, k in enumerate(examples["id"])}
@ -400,7 +403,8 @@ def postprocess_qa_predictions_with_beam_search(
# If we have an output_dir, let's save all those dicts. # If we have an output_dir, let's save all those dicts.
if output_dir is not None: if output_dir is not None:
assert os.path.isdir(output_dir), f"{output_dir} is not a directory." if not os.path.isdir(output_dir):
raise EnvironmentError(f"{output_dir} is not a directory.")
prediction_file = os.path.join( prediction_file = os.path.join(
output_dir, "predictions.json" if prefix is None else f"{prefix}_predictions.json" output_dir, "predictions.json" if prefix is None else f"{prefix}_predictions.json"

20
examples/tensorflow/question-answering/utils_qa.py
View File

@ -73,10 +73,12 @@ def postprocess_qa_predictions(
log_level (:obj:`int`, `optional`, defaults to ``logging.WARNING``): log_level (:obj:`int`, `optional`, defaults to ``logging.WARNING``):
``logging`` log level (e.g., ``logging.WARNING``) ``logging`` log level (e.g., ``logging.WARNING``)
""" """
assert len(predictions) == 2, "`predictions` should be a tuple with two elements (start_logits, end_logits)." if len(predictions) != 2:
raise ValueError("`predictions` should be a tuple with two elements (start_logits, end_logits).")
all_start_logits, all_end_logits = predictions all_start_logits, all_end_logits = predictions
assert len(predictions[0]) == len(features), f"Got {len(predictions[0])} predictions and {len(features)} features." if len(predictions[0]) != len(features):
raise ValueError(f"Got {len(predictions[0])} predictions and {len(features)} features.")
# Build a map example to its corresponding features. # Build a map example to its corresponding features.
example_id_to_index = {k: i for i, k in enumerate(examples["id"])} example_id_to_index = {k: i for i, k in enumerate(examples["id"])}
@ -212,7 +214,8 @@ def postprocess_qa_predictions(
# If we have an output_dir, let's save all those dicts. # If we have an output_dir, let's save all those dicts.
if output_dir is not None: if output_dir is not None:
assert os.path.isdir(output_dir), f"{output_dir} is not a directory." if not os.path.isdir(output_dir):
raise EnvironmentError(f"{output_dir} is not a directory.")
prediction_file = os.path.join( prediction_file = os.path.join(
output_dir, "predictions.json" if prefix is None else f"{prefix}_predictions.json" output_dir, "predictions.json" if prefix is None else f"{prefix}_predictions.json"
@ -283,12 +286,12 @@ def postprocess_qa_predictions_with_beam_search(
log_level (:obj:`int`, `optional`, defaults to ``logging.WARNING``): log_level (:obj:`int`, `optional`, defaults to ``logging.WARNING``):
``logging`` log level (e.g., ``logging.WARNING``) ``logging`` log level (e.g., ``logging.WARNING``)
""" """
assert len(predictions) == 5, "`predictions` should be a tuple with five elements." if len(predictions) != 5:
raise ValueError("`predictions` should be a tuple with five elements.")
start_top_log_probs, start_top_index, end_top_log_probs, end_top_index, cls_logits = predictions start_top_log_probs, start_top_index, end_top_log_probs, end_top_index, cls_logits = predictions
assert len(predictions[0]) == len( if len(predictions[0]) != len(features):
features raise ValueError(f"Got {len(predictions[0])} predictions and {len(features)} features.")
), f"Got {len(predictions[0])} predicitions and {len(features)} features."
# Build a map example to its corresponding features. # Build a map example to its corresponding features.
example_id_to_index = {k: i for i, k in enumerate(examples["id"])} example_id_to_index = {k: i for i, k in enumerate(examples["id"])}
@ -400,7 +403,8 @@ def postprocess_qa_predictions_with_beam_search(
# If we have an output_dir, let's save all those dicts. # If we have an output_dir, let's save all those dicts.
if output_dir is not None: if output_dir is not None:
assert os.path.isdir(output_dir), f"{output_dir} is not a directory." if not os.path.isdir(output_dir):
raise EnvironmentError(f"{output_dir} is not a directory.")
prediction_file = os.path.join( prediction_file = os.path.join(
output_dir, "predictions.json" if prefix is None else f"{prefix}_predictions.json" output_dir, "predictions.json" if prefix is None else f"{prefix}_predictions.json"