mirror of
https://github.com/huggingface/transformers.git
synced 2025-07-20 04:58:22 +06:00

* Initial commit * Just a copy of modeling_idefics.py that will be ported to TF * - Prepend TF to the name of all classes - Convert pytorch ops to TF (not all operations are converted yet) * Add TF imports * Add autotranslated files * Add TF classes to model_tf_auto.py * Add the TF classes in model_doc * include auto-translated code * Adopted from auto-translated version * Add a forgotten super().build * Add test code for TF version. * Fix indentation and load pytorch weights for now * Some fixes. Many tests are still failing but some are passing now. - I have added TODO's for some of the hacks I made to unblock me and I will address them soon - I have the processing_idefics.py hacked in my view to support TF temporarily * Add ALL_LAYERNORM_LAYERS to match pytorch * Revert "Add ALL_LAYERNORM_LAYERS to match pytorch" This reverts commit 7e0a35119b4d7a6284d04d8c543fba1b29e573c9 as it is not needed in the tf implementation. * Fix freeze_relevant_params() * Some more fixes * Fix test_attention_outputs * Add tf stuff to processing_idefics.py processing_idefics.py supports both pytorch and tf now. test_processor_idefics.py for pytorch is passing, so i didn't break anything but still some issues with tf. I also need to add tf tests in test_processor_idefics.py. * Pass return_tensors to image processing code and fix test * Pass return_tensors to the image processor __init__ * Fix several test cases - Make input to some of the forward pass of type `TFModelInputType` - Decorate main layer forward pass with `@unpack_inputs` - Decorate main layer with `@keras_serializable` - Pass `inputs` to TFIdeficsModel * Some more fixes forgotten in last commit * Fix processing code and vision_tf.py * Fix perceiver bug * Import from * Auto-add build() methods + style pass * Fix build() errors due to `None` being passed as shape to some layers * Change name in TFIdeficsForVisionText2Text to attribute in IdeficsForVisionText2Text * Fix pytorch weights load for tf2 There were a lot of `name=` missing in weight initialization code. * Attempt to fix CI * Add back accidently removed line * Remove torch-specific stuff from the TF test file * make fix-copies, make style, remove autotranslated files * Fixes to imports/docstrings * Let's try the from future import in desperation * Fix the core random_attention_mask fn to match the torch/flax behaviour * Clean random_attention_mask up correctly * Remove torch-only test * Fix loss shape, couple of nits * make style * Don't test for OOB embeddings because IDEFICS uses those deliberately * Fix loss computation to handle masking * Fix test failures when flattening * Fix some test failures - Add cross attention gate which was missing and wasn't being passed arround - Fix overwriting of image_attention_mask due to hack I had for dummy inputs * Add a proper stateless scaled_dot_product_attention * make style * Adding missing attribute from the PyTorch version * Small cleanups to decoupledlinearlayer in case that helps * Pass epsilon to LayerNormalization * Attemp to fix pytorch weight cross-loading for TFIdeficsEmbedding * Fix a bug in TFIdeficsGatedCrossAttentionLayer * Patching up build() methods * Constant self.inv_freq * Constant self.inv_freq * First working version The TF implementation works now, there was a bug in the TFIdeficsDecoupledLinear where the weights were mis-intialized (in_features,out_features) when it should be: (out_features, in_features) I have tested this so far with tiny-random and idefics-9b-instruct and gives correct output. I also dumped the final outputs for both pytorch and TF and they are identical. * Fix some test failures * remove print statement * Fix return_tensors * Fix CI test failure check_code_quality * Attempt to fix CI failures by running `make fixup` The hardcoded IDs in test_modeling_tf_idefics.py are for the integration test and makes that file unreadable and should probably be moved to a seperate file. * Attempt to fix tests_pr_documentation_tests * Fix a test failure in test_image_processing_idefics.py * Fix test test_pt_tf_model_equivalence * Fix a few failures * Tiny fix * Some minor fixes * Remove a duplicate test * Override a few test failures for IDEFICS - `test_keras_save_load` is passing now - `test_compile_tf_model` is still failing * Fix processing_idefics.py after rebase * Guard import keras with is_tf_available * fix check code quality * fix check code quality * Minor fixes * Skip test_save_load temporarily This test passed on my local box but fails on the CI, skipping for now to see if there are other remaining failures on the CI. * Run `ruff format tests src utils` * Fix last failing test, `test_compile_tf_model` * Add fixes for vision_tf.py I forgot to add this file in last commit. * Minor fixes * Replace "<<<" with "<<" for doc tests IDEFICS-9B is too big for doctest runner, so don't run it there * Make code more readable * Fix bug after code review I added a layer_norm_eps to IdeficsConfig but I don't even need it since the vision config has a layer_norm_eps. * Fix after code review Use original code tokenizer.convert_tokens_to_ids * Keep PyTorch as the default return_tensors * Fixes to modeling_tf after code review * Fixes from code review - Remove all references of `TF_IDEFICS_PRETRAINED_MODEL_ARCHIVE_LIST` - Pass 1e-5 to LayerNormalization in perceiver * Run ruff * Undo a change * Refactor processing code after Matt's suggestion * Remove TODO's that aren't needed anymore * For pytorch, Use original pytorch processing code from main Since this PR is a TF port it shouldn't make any modifications to pytorch IDEFICS code. This changes undo's the pytorch processing modifications I made and uses original code from main. * Update tests/models/idefics/test_modeling_idefics.py * Update tests/models/idefics/test_modeling_tf_idefics.py * Add missing imports for is_pt_tf_cross_test * [DO NOT MERGE]: This is a commit for debugging and will be reverted The cross test `test_pt_tf_model_equivalence` passes locally but fails when running on the CI. This commit is to help debug that and will be reverted. * Revert "[DO NOT MERGE]: This is a commit for debugging and will be reverted" This reverts commit 8f0d709ec5bd46685fb0b4259d914ffee794875b. * [DO NOT MERGE]: This commit is for debugging a CI failure and will be reverted * [DO NOT MERGE]: This commit is for debugging a CI failure and will be reverted * Revert "[DO NOT MERGE]: This commit is for debugging a CI failure and will be reverted" This reverts commit 998cc38b8c3d313bf5e5eb55a7f5b7b881897b89. * Revert "[DO NOT MERGE]: This commit is for debugging a CI failure and will be reverted" This reverts commit 1c695ac4219c4ae4d39b330b01744dc27deb7dd4. * Don't skip test_save_load IIRC test_save_load was also failing on the CI but not on my local box, it might be easier to debug that on the CI first than the cross tests * Debugging commit, will be reverted * Revert "Debugging commit, will be reverted" This reverts commit 8eafc8e41e20c4e95a3a90834f06a6e9f445e2d5. * Override `test_save_load` and push model to save Maybe this will help me repro this weird bug * pass my repo_id * add endpoint * Pass a temp (write) token just for this CI * Undo last few commits, still pushing to hub for model debugging The issue seems to be with save_pretrained(), when I looked at the model saved from the CI test failure it is basically empty and has no weights. `self.save_weights(..)` seems to be failing in save_pretrained but needs more debugging * Add logging to modeling tf utils, will be reverted just for debugging * Debugging, will revert * Revert "Debugging, will revert" This reverts commit 9d0d3075fb7c82d8cde3a5c76bc8f3876c5c55d3. * Revert "Add logging to modeling tf utils, will be reverted just for debugging" This reverts commit 774b6b7b1c17b3ce5d7634ade768f2f686cee617. * Remove `test_save_load` The CI failures are gone after my latest rebase, no idea why but I was still saving the model to my hub on HF and the tf_model.h5 file now has everything. * Run make fix-copies * Run ruff format tests src utils * Debugging commit, will be reverted * Run ruff, also trigger CI run * Run ruff again * Undo debugging commit --------- Co-authored-by: Matt <rocketknight1@gmail.com> Co-authored-by: Matt <Rocketknight1@users.noreply.github.com>
211 lines
8.2 KiB
Python
211 lines
8.2 KiB
Python
# Copyright 2022 The HuggingFace Team. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import numpy as np
|
|
|
|
from transformers.testing_utils import TestCasePlus, require_torch, require_vision
|
|
from transformers.utils import is_torch_available, is_vision_available
|
|
|
|
|
|
if is_torch_available():
|
|
import torch
|
|
|
|
if is_vision_available():
|
|
from PIL import Image
|
|
|
|
from transformers import (
|
|
AutoProcessor,
|
|
IdeficsImageProcessor,
|
|
IdeficsProcessor,
|
|
LlamaTokenizerFast,
|
|
PreTrainedTokenizerFast,
|
|
)
|
|
|
|
|
|
@require_torch
|
|
@require_vision
|
|
class IdeficsProcessorTest(TestCasePlus):
|
|
def setUp(self):
|
|
super().setUp()
|
|
|
|
self.checkpoint_path = self.get_auto_remove_tmp_dir()
|
|
|
|
image_processor = IdeficsImageProcessor(return_tensors="pt")
|
|
tokenizer = LlamaTokenizerFast.from_pretrained("HuggingFaceM4/tiny-random-idefics")
|
|
|
|
processor = IdeficsProcessor(image_processor, tokenizer)
|
|
|
|
processor.save_pretrained(self.checkpoint_path)
|
|
|
|
self.input_keys = ["pixel_values", "input_ids", "attention_mask", "image_attention_mask"]
|
|
|
|
def get_tokenizer(self, **kwargs):
|
|
return AutoProcessor.from_pretrained(self.checkpoint_path, **kwargs).tokenizer
|
|
|
|
def get_image_processor(self, **kwargs):
|
|
return AutoProcessor.from_pretrained(self.checkpoint_path, **kwargs).image_processor
|
|
|
|
def prepare_prompts(self):
|
|
"""This function prepares a list of PIL images"""
|
|
|
|
num_images = 2
|
|
images = [np.random.randint(255, size=(3, 30, 400), dtype=np.uint8) for x in range(num_images)]
|
|
images = [Image.fromarray(np.moveaxis(x, 0, -1)) for x in images]
|
|
|
|
# print([type(x) for x in images])
|
|
# die
|
|
|
|
prompts = [
|
|
# text and 1 image
|
|
[
|
|
"User:",
|
|
images[0],
|
|
"Describe this image.\nAssistant:",
|
|
],
|
|
# text and images
|
|
[
|
|
"User:",
|
|
images[0],
|
|
"Describe this image.\nAssistant: An image of two dogs.\n",
|
|
"User:",
|
|
images[1],
|
|
"Describe this image.\nAssistant:",
|
|
],
|
|
# only text
|
|
[
|
|
"User:",
|
|
"Describe this image.\nAssistant: An image of two kittens.\n",
|
|
"User:",
|
|
"Describe this image.\nAssistant:",
|
|
],
|
|
# only images
|
|
[
|
|
images[0],
|
|
images[1],
|
|
],
|
|
]
|
|
|
|
return prompts
|
|
|
|
def test_save_load_pretrained_additional_features(self):
|
|
processor = IdeficsProcessor(tokenizer=self.get_tokenizer(), image_processor=self.get_image_processor())
|
|
processor.save_pretrained(self.checkpoint_path)
|
|
|
|
tokenizer_add_kwargs = self.get_tokenizer(bos_token="(BOS)", eos_token="(EOS)")
|
|
image_processor_add_kwargs = self.get_image_processor(do_normalize=False, padding_value=1.0)
|
|
|
|
processor = IdeficsProcessor.from_pretrained(
|
|
self.checkpoint_path, bos_token="(BOS)", eos_token="(EOS)", do_normalize=False, padding_value=1.0
|
|
)
|
|
|
|
self.assertEqual(processor.tokenizer.get_vocab(), tokenizer_add_kwargs.get_vocab())
|
|
self.assertIsInstance(processor.tokenizer, PreTrainedTokenizerFast)
|
|
|
|
self.assertEqual(processor.image_processor.to_json_string(), image_processor_add_kwargs.to_json_string())
|
|
self.assertIsInstance(processor.image_processor, IdeficsImageProcessor)
|
|
|
|
def test_processor(self):
|
|
image_processor = self.get_image_processor()
|
|
tokenizer = self.get_tokenizer()
|
|
|
|
processor = IdeficsProcessor(tokenizer=tokenizer, image_processor=image_processor)
|
|
|
|
prompts = self.prepare_prompts()
|
|
|
|
# test that all prompts succeeded
|
|
input_processor = processor(prompts, return_tensors="pt", padding="longest")
|
|
for key in self.input_keys:
|
|
assert torch.is_tensor(input_processor[key])
|
|
|
|
def test_tokenizer_decode(self):
|
|
image_processor = self.get_image_processor()
|
|
tokenizer = self.get_tokenizer()
|
|
|
|
processor = IdeficsProcessor(tokenizer=tokenizer, image_processor=image_processor, return_tensors="pt")
|
|
|
|
predicted_ids = [[1, 4, 5, 8, 1, 0, 8], [3, 4, 3, 1, 1, 8, 9]]
|
|
|
|
decoded_processor = processor.batch_decode(predicted_ids)
|
|
decoded_tok = tokenizer.batch_decode(predicted_ids)
|
|
|
|
self.assertListEqual(decoded_tok, decoded_processor)
|
|
|
|
def test_tokenizer_padding(self):
|
|
image_processor = self.get_image_processor()
|
|
tokenizer = self.get_tokenizer(padding_side="right")
|
|
|
|
processor = IdeficsProcessor(tokenizer=tokenizer, image_processor=image_processor, return_tensors="pt")
|
|
|
|
predicted_tokens = [
|
|
"<s> Describe this image.\nAssistant:<unk><unk><unk><unk><unk><unk><unk><unk><unk>",
|
|
"<s> Describe this image.\nAssistant:<unk><unk><unk><unk><unk><unk><unk><unk><unk><unk>",
|
|
]
|
|
predicted_attention_masks = [
|
|
([1] * 10) + ([0] * 9),
|
|
([1] * 10) + ([0] * 10),
|
|
]
|
|
prompts = [[prompt] for prompt in self.prepare_prompts()[2]]
|
|
|
|
max_length = processor(prompts, padding="max_length", truncation=True, max_length=20, return_tensors="pt")
|
|
longest = processor(prompts, padding="longest", truncation=True, max_length=30, return_tensors="pt")
|
|
|
|
decoded_max_length = processor.tokenizer.decode(max_length["input_ids"][-1])
|
|
decoded_longest = processor.tokenizer.decode(longest["input_ids"][-1])
|
|
|
|
self.assertEqual(decoded_max_length, predicted_tokens[1])
|
|
self.assertEqual(decoded_longest, predicted_tokens[0])
|
|
|
|
self.assertListEqual(max_length["attention_mask"][-1].tolist(), predicted_attention_masks[1])
|
|
self.assertListEqual(longest["attention_mask"][-1].tolist(), predicted_attention_masks[0])
|
|
|
|
def test_tokenizer_left_padding(self):
|
|
"""Identical to test_tokenizer_padding, but with padding_side not explicitly set."""
|
|
image_processor = self.get_image_processor()
|
|
tokenizer = self.get_tokenizer()
|
|
|
|
processor = IdeficsProcessor(tokenizer=tokenizer, image_processor=image_processor)
|
|
|
|
predicted_tokens = [
|
|
"<unk><unk><unk><unk><unk><unk><unk><unk><unk><s> Describe this image.\nAssistant:",
|
|
"<unk><unk><unk><unk><unk><unk><unk><unk><unk><unk><s> Describe this image.\nAssistant:",
|
|
]
|
|
predicted_attention_masks = [
|
|
([0] * 9) + ([1] * 10),
|
|
([0] * 10) + ([1] * 10),
|
|
]
|
|
prompts = [[prompt] for prompt in self.prepare_prompts()[2]]
|
|
max_length = processor(prompts, padding="max_length", truncation=True, max_length=20)
|
|
longest = processor(prompts, padding="longest", truncation=True, max_length=30)
|
|
|
|
decoded_max_length = processor.tokenizer.decode(max_length["input_ids"][-1])
|
|
decoded_longest = processor.tokenizer.decode(longest["input_ids"][-1])
|
|
|
|
self.assertEqual(decoded_max_length, predicted_tokens[1])
|
|
self.assertEqual(decoded_longest, predicted_tokens[0])
|
|
|
|
self.assertListEqual(max_length["attention_mask"][-1].tolist(), predicted_attention_masks[1])
|
|
self.assertListEqual(longest["attention_mask"][-1].tolist(), predicted_attention_masks[0])
|
|
|
|
def test_model_input_names(self):
|
|
image_processor = self.get_image_processor()
|
|
tokenizer = self.get_tokenizer()
|
|
|
|
processor = IdeficsProcessor(tokenizer=tokenizer, image_processor=image_processor)
|
|
prompts = self.prepare_prompts()
|
|
|
|
inputs = processor(prompts, padding="longest", return_tensors="pt")
|
|
|
|
# For now the processor supports only ['pixel_values', 'input_ids', 'attention_mask']
|
|
self.assertSetEqual(set(inputs.keys()), set(self.input_keys))
|