From b21a30bdd8d60e4b1fe071e5f3f653ee93c761c9 Mon Sep 17 00:00:00 2001 From: Stas Bekman Date: Tue, 6 Oct 2020 02:25:21 -0700 Subject: [PATCH] [makefile] check only .py files (#7588) * check only .py files * better choice of words --- Makefile | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/Makefile b/Makefile index 637d1616c32..0b3eb5f27fe 100644 --- a/Makefile +++ b/Makefile @@ -5,18 +5,18 @@ check_dirs := examples templates tests src utils # get modified files since the branch was made fork_point_sha := $(shell git merge-base --fork-point master) -joined_dirs := $(shell echo $(check_dirs) | tr " " "|") -modified_files := $(shell git diff --name-only $(fork_point_sha) | egrep '^($(joined_dirs))') -#$(info modified files are: $(modified_files)) +joined_dirs := $(shell echo $(check_dirs) | tr " " "|") +modified_py_files := $(shell git diff --name-only $(fork_point_sha) | egrep '^($(joined_dirs))' | egrep '\.py$$') +#$(info modified files are: $(modified_py_files)) modified_only_fixup: - @if [ -n "$(modified_files)" ]; then \ - echo "Checking/fixing $(modified_files)"; \ - black $(modified_files); \ - isort $(modified_files); \ - flake8 $(modified_files); \ + @if [ -n "$(modified_py_files)" ]; then \ + echo "Checking/fixing $(modified_py_files)"; \ + black $(modified_py_files); \ + isort $(modified_py_files); \ + flake8 $(modified_py_files); \ else \ - echo "No relevant files were modified"; \ + echo "No library .py files were modified"; \ fi # Check that source code meets quality standards